slog support: fix WithGroup + WithValues combination #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pohly
force-pushed
the
withgroup-sink-fix
branch
from
9c56186 to
5572aef
Compare
This turns testLogSink into an implementation of SlogSink if slog is supported, then runs through some scenarios where values get added using different APIs. The end result gets compared by formatting with the slog JSON handler because that is easier than writing custom code for a deep-equal comparison of slog attributes. The "with-group-and-logr-values" is the case which was broken.
pohly
force-pushed
the
withgroup-sink-fix
branch
from
5572aef to
ffd51a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The invalid initialization of the
sinkfield in theWithGroupmethod was found by @thockin during code reading.This PR adds unit testing that fails without that fix.