slogr: restore original backend when converting back and forth #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works both ways by checking whether the backend is one of our own wrappers. There's one exception: when the verbosity level was modified, we cannot use the original slog.Handler because it doesn't know about that modification. The downside is that we have to adjust the stack unwinding each time a record is handled, because we need the original sink without that adjustment. This only gets done when actually emitting a log record, so that overhead should be okay. It will disappear entirely once sinks directly support writing a slog.Event. A second copy would work, but then that copy would need to be updated alongside the other one in WithAttrs, which causes overhead along a callchain also when the log record does not get emitted. The code also would be more complex.
|
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works both ways by checking whether the backend is one of our own wrappers. There's one exception: when the verbosity level was modified, we cannot use the original slog.Handler because it doesn't know about that modification.
The downside is that we have to adjust the stack unwinding each time a record is handled, because we need the original sink without that adjustment. This only gets done when actually emitting a log record, so that overhead should be okay. It will disappear entirely once sinks directly support writing a slog.Event.
A second copy would work, but then that copy would need to be updated alongside the other one in WithAttrs, which causes overhead along a callchain also when the log record does not get emitted. The code also would be more complex.