Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cut tag for current master #240

Closed
jefferai opened this issue Nov 4, 2019 · 7 comments · Fixed by #241
Closed

Cut tag for current master #240

jefferai opened this issue Nov 4, 2019 · 7 comments · Fixed by #241
Assignees
@johnweldon

Comments

@jefferai
Copy link
Contributor

jefferai commented Nov 4, 2019

With the change to go.mod it would be nice if that were tagged so that we can use it in a compatible way (e.g. github.com/go-ldap/ldap/v3).
@johnweldon
Copy link
Member

v3.1.1

@jefferai
Copy link
Contributor Author

jefferai commented Nov 4, 2019

Apologies, I forgot that also the go.mod needs to be /v3

@johnweldon johnweldon reopened this Nov 4, 2019
@johnweldon johnweldon self-assigned this Nov 4, 2019
@jefferai
Copy link
Contributor Author

jefferai commented Nov 4, 2019

@ncabatoff CC

@johnweldon
Copy link
Member

@jefferai feel free to make a PR for the specific change you need.

@jefferai
Copy link
Contributor Author

jefferai commented Nov 5, 2019

Thanks -- see #241

@jefferai jefferai mentioned this issue Nov 5, 2019
Merged
@johnweldon
Copy link
Member

I think this has been resolved by #243

@johnweldon
Copy link
Member

And module version v3.1.2

@johnweldon johnweldon mentioned this issue Nov 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnweldon johnweldon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update go.mod jefferai/ldap
2 participants
@jefferai @johnweldon