Revert #499: Mark public Start function as deprecated (#508)

* Revert "chore: add comment to `Start` function to inform about possible instability when called (#499)" This reverts commit f09ee91. * chore: add warning to `Start` comment to inform about possible race conditions
go-ldap · Apr 12, 2024 · 06d50d1 · 06d50d1
1 parent 2260012
commit 06d50d1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/conn.go b/conn.go
@@ -266,10 +266,9 @@ func NewConn(conn net.Conn, isTLS bool) *Conn {
 }
 
 // Start initialises goroutines to read replies and process messages.
+// Warning: Calling this function in addition to Dial or DialURL
+// may cause race conditions.
 //
-// Deprecated: It is usually not necessary to call this function
-// manually. It is public for compatibility reasons and may
-// cause a race condition when processing messages.
 // See: https://github.com/go-ldap/ldap/issues/356
 func (l *Conn) Start() {
 	go l.reader()

diff --git a/v3/conn.go b/v3/conn.go
@@ -266,10 +266,9 @@ func NewConn(conn net.Conn, isTLS bool) *Conn {
 }
 
 // Start initialises goroutines to read replies and process messages.
+// Warning: Calling this function in addition to Dial or DialURL
+// may cause race conditions.
 //
-// Deprecated: It is usually not necessary to call this function
-// manually. It is public for compatibility reasons and may
-// cause a race condition when processing messages.
 // See: https://github.com/go-ldap/ldap/issues/356
 func (l *Conn) Start() {
 	go l.reader()