-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kafka transport implementation #1209
Comments
I don't think there is a section in the readme for third-party transport implementations, so your may be the first one. I'd say feel free to open a PR and add it somewhere in the readme (maybe below or above the code generator section). @peterbourgon do you have any preference? |
@alebabai while I appreciate the effort in making this cleanly written and well-documented repo, I think it treats Kafka as a pub/sub, instead of an RPC transport. All other modules in go-kit focus on Request-Response pattern only, including AMQP. |
@Reasno Hi, thanks for feedback. |
We're not merging new transports, but I'm happy to add a section to the README for this. I think there are probably several more that warrant inclusion. Please open a new PR! |
What would you like?
Hi,
I've implemented module with Apache Kafka transport abstractions for use with go-kit.
It follows common go-kit code style, has documentation and examples (separate modules).
If you find this interesting and useful, it would be great if you could leave a link to it somewhere.
For community: any help, advice, contribution is appreciated.
Thanks.
https://github.com/alebabai/go-kit-kafka
The text was updated successfully, but these errors were encountered: