clarify loggingMiddleware is not yet defined #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While following the tutorial (and thanks a lot for it), on the Transport Logging section, I got an error that loggingMiddleware is not defined, up to that point I had followed the code snippets and run/test, took me a while to understand the code wasn't ready to be ran. There's an open issue go-kit#17 which also pointed this out but the pull request doesn't address this part. Thank you for your awesome work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While following the tutorial (and thanks a lot for it), on the Transport Logging section, I got an error that loggingMiddleware is not defined, up to that point I had followed the code snippets and run/test, took me a while to understand the code wasn't ready to be ran. There's an open issue #17 which also pointed this out but the pull request doesn't address this part. Thank you for your awesome work!