Skip to content

feat: add preliminary json support for qrm_pgx. #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: pgx
Choose a base branch
from

Conversation

DevX86
Copy link

@DevX86 DevX86 commented Apr 28, 2025

No description provided.

@DevX86
Copy link
Author

DevX86 commented Apr 28, 2025

@go-jet Something like this?

@DevX86
Copy link
Author

DevX86 commented Apr 29, 2025

Self reminder on the stmt.QueryPGX() to avoid the

query, args := stmt.Sql()
_, err := qrm.QueryPGX(ctx, r.db, query, args, row)
if err != nil {
	return err
}
	
return nil

We want to make a statement.go type pgx implementation but also wanted to avoid PGX spam on the stmt. intellisense.
Two ideas were put forth, stmt.PGX.Query() and pgx.Query() personally, leading towards the latter, less dots and it gives things a more modular development experience.

@go-jet
Copy link
Owner

go-jet commented Apr 30, 2025

@go-jet Something like this?

Yeah, looks good.

Copy link

codecov bot commented May 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 51 lines in your changes missing coverage. Please review.

Project coverage is 90.39%. Comparing base (0a336d6) to head (837bd92).

Files with missing lines Patch % Lines
qrm/qrm_pgx.go 0.00% 51 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##              pgx     #495      +/-   ##
==========================================
- Coverage   90.94%   90.39%   -0.55%     
==========================================
  Files         137      137              
  Lines        8422     8473      +51     
==========================================
  Hits         7659     7659              
- Misses        574      625      +51     
  Partials      189      189              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants