Skip to content

feat: add preliminary json support for qrm_pgx. - #495

Merged
go-jet merged 2 commits into
go-jet:pgxfrom
DevX86:pgx
Oct 7, 2025
Merged

feat: add preliminary json support for qrm_pgx.#495
go-jet merged 2 commits into
go-jet:pgxfrom
DevX86:pgx

Conversation

@DevX86

@DevX86 DevX86 commented Apr 28, 2025

Copy link
Copy Markdown

No description provided.

@DevX86

DevX86 commented Apr 28, 2025

Copy link
Copy Markdown
Author

@go-jet Something like this?

@DevX86

DevX86 commented Apr 29, 2025

Copy link
Copy Markdown
Author

Self reminder on the stmt.QueryPGX() to avoid the

query, args := stmt.Sql()
_, err := qrm.QueryPGX(ctx, r.db, query, args, row)
if err != nil {
	return err
}
	
return nil

We want to make a statement.go type pgx implementation but also wanted to avoid PGX spam on the stmt. intellisense.
Two ideas were put forth, stmt.PGX.Query() and pgx.Query() personally, leading towards the latter, less dots and it gives things a more modular development experience.

@go-jet

go-jet commented Apr 30, 2025

Copy link
Copy Markdown
Owner

@go-jet Something like this?

Yeah, looks good.

Comment thread qrm/qrm_pgx.go Outdated
@codecov

codecov Bot commented May 4, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 51 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.39%. Comparing base (0a336d6) to head (837bd92).
⚠️ Report is 3 commits behind head on pgx.

Files with missing lines Patch % Lines
qrm/qrm_pgx.go 0.00% 51 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##              pgx     #495      +/-   ##
==========================================
- Coverage   90.94%   90.39%   -0.55%     
==========================================
  Files         137      137              
  Lines        8422     8473      +51     
==========================================
  Hits         7659     7659              
- Misses        574      625      +51     
  Partials      189      189              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@go-jet
go-jet merged commit d590f72 into go-jet:pgx Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants