You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would like to suggest the following small change in clause/limit.go file regarding code readability
the type Limit is described the following way
typeLimitstruct {
Limit*intOffsetint
}
this is extremely confusing for someone reading the code the field named Limit inside of Limit type
can we change it to something like "MaxRows" , "LimitValue" e.t.c , that would make it very readable
and secondly (i am not sure about this one , open to suggestions) the following code has redundancy that it is making the
same checks twice , can't we improve this , by reducing the redundancy?
The issue has been automatically marked as stale as it missing playground pull request link, which is important to help others understand your issue effectively and make sure the issue hasn't been fixed on latest master, checkout https://github.com/go-gorm/playground for details. it will be closed in 30 days if no further activity occurs. if you are asking question, please use the Question template, most likely your question already answered https://github.com/go-gorm/gorm/issues or described in the document https://gorm.io ✨ Search Before Asking ✨
the type Limit is described the following way
this is extremely confusing for someone reading the code the field named Limit inside of Limit type
can we change it to something like "MaxRows" , "LimitValue" e.t.c , that would make it very readable
and secondly (i am not sure about this one , open to suggestions) the following code has redundancy that it is making the
same checks twice , can't we improve this , by reducing the redundancy?
The text was updated successfully, but these errors were encountered: