This repository has been archived by the owner on Jun 8, 2019. It is now read-only.
Preparation for Issue due dates (go-gitea/gitea#2533) #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolaente
added a commit
to kolaente/gitea
that referenced
this pull request
Apr 14, 2018
|
LGTM |
jonasfranz
suggested changes
Apr 15, 2018
gitea/issue.go
Outdated
| Assignees []string `json:"assignees"` | ||
| Milestone *int64 `json:"milestone"` | ||
| State *string `json:"state"` | ||
| Deadline *time.Time `json:"due_date"` |
There was a problem hiding this comment.
deadline should also be added to CreateIssueOption
There was a problem hiding this comment.
Add // swagger:strfmt date-time
There was a problem hiding this comment.
deadline should also be added to CreateIssueOption
It is, see line 99.
gitea/issue.go
Outdated
| @@ -94,6 +96,8 @@ type CreateIssueOption struct { | |||
| // username of assignee | |||
| Assignee string `json:"assignee"` | |||
| Assignees []string `json:"assignees"` | |||
| // deadline | |||
| Deadline *time.Time `json:"due_date"` | |||
There was a problem hiding this comment.
Add // swagger:strfmt date-time
gitea/pull.go
Outdated
| Assignees []string `json:"assignees"` | ||
| Milestone int64 `json:"milestone"` | ||
| Labels []int64 `json:"labels"` | ||
| Deadline *time.Time `json:"due_date"` |
There was a problem hiding this comment.
Add // swagger:strfmt date-time
gitea/pull.go
Outdated
| Milestone int64 `json:"milestone"` | ||
| Labels []int64 `json:"labels"` | ||
| State *string `json:"state"` | ||
| Deadline *time.Time `json:"due_date"` |
There was a problem hiding this comment.
Add // swagger:strfmt date-time
|
@JonasFranzDEV fixed. |
|
LGTM |
lafriks
pushed a commit
to go-gitea/gitea
that referenced
this pull request
May 1, 2018
* Started adding deadline to ui * Implemented basic issue due date managing * Improved UI for due date managing * Added at least write access to the repo in order to modify issue due dates * Ui improvements * Added issue comments creation when adding/modifying/removing a due date * Show due date in issue list * Added api support for issue due dates * Fixed lint suggestions * Added deadline to sdk * Updated css * Added support for adding/modifiying deadlines for pull requests via api * Fixed comments not created when updating or removing a deadline * update sdk (will do properly once go-gitea/go-sdk#103 is merged) * enhanced updateIssueDeadline * Removed unnessecary Issue.DeadlineString * UI improvements * Small improvments to comment creation + ui & validation improvements * Check if an issue is overdue is now a seperate function * Updated go-sdk with govendor as it was merged * Simplified isOverdue method * removed unessecary deadline to 0 set * Update swagger definitions * Added missing return * Added an explanary comment * Improved updateIssueDeadline method so it'll only update `deadline_unix` * Small changes and improvements * no need to explicitly load the issue when updating a deadline, just use whats already there * small optimisations * Added check if a deadline was modified before updating it * Moved comment creating logic into its own function * Code cleanup for creating deadline comment * locale improvement * When modifying a deadline, the old deadline is saved with the comment * small improvments to xorm session handling when updating an issue deadline + style nitpicks * style nitpicks * Moved checking for if the user has write acces to middleware
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently implementing go-gitea/gitea#2533, this pr should be merged before go-gitea/gitea#3794.
Blocks go-gitea/gitea#3794.