Skip to content

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 10, 2020

As title.

@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Jan 10, 2020
@codecov-io
Copy link

Codecov Report

Merging #9688 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9688      +/-   ##
==========================================
- Coverage   42.32%   42.24%   -0.08%     
==========================================
  Files         587      587              
  Lines       77991    77993       +2     
==========================================
- Hits        33009    32950      -59     
- Misses      40923    41001      +78     
+ Partials     4059     4042      -17
Impacted Files Coverage Δ
services/pull/check.go 53.37% <0%> (-0.05%) ⬇️
modules/util/sanitize.go 0% <0%> (-63.16%) ⬇️
modules/task/migrate.go 10.52% <0%> (-14.48%) ⬇️
models/task.go 24.13% <0%> (-10.35%) ⬇️
modules/migrations/migrate.go 21.57% <0%> (-4.22%) ⬇️
modules/repository/repo.go 33.55% <0%> (-1.98%) ⬇️
modules/migrations/gitea.go 7.98% <0%> (-1.69%) ⬇️
models/webhook.go 69.39% <0%> (-1.07%) ⬇️
models/repo.go 47.87% <0%> (-0.11%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17b844a...af917cd. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 10, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 10, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 10, 2020
@lunny lunny merged commit 8878cfa into go-gitea:master Jan 10, 2020
@lunny lunny deleted the lunny/fix_lint branch January 10, 2020 05:50
@zeripath
Copy link
Contributor

Sorry!!

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants