Skip to content

tests: add attachement tests integration #9309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 10, 2019

Conversation

sapk
Copy link
Member

@sapk sapk commented Dec 10, 2019

Extracted from #7956, to make them work before changing (rebasing) anything.

I haven't very much time lately to do a rebase of the PR in one-shoot. I think this could be already merged as it add more test on current code and it will ease the review later when I rebase the PR with fix.

@sapk sapk added this to the 1.12.0 milestone Dec 10, 2019
@sapk sapk modified the milestones: 1.12.0, 1.11.0 Dec 10, 2019
@codecov-io
Copy link

codecov-io commented Dec 10, 2019

Codecov Report

Merging #9309 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9309      +/-   ##
==========================================
+ Coverage   41.17%   41.19%   +0.02%     
==========================================
  Files         559      559              
  Lines       73101    73101              
==========================================
+ Hits        30096    30116      +20     
+ Misses      39235    39209      -26     
- Partials     3770     3776       +6
Impacted Files Coverage Δ
models/unit.go 62.16% <0%> (-5.41%) ⬇️
routers/repo/view.go 38.59% <0%> (-0.88%) ⬇️
modules/context/context.go 52.85% <0%> (+0.47%) ⬆️
routers/routes/routes.go 83.25% <0%> (+0.59%) ⬆️
models/release.go 51.13% <0%> (+0.9%) ⬆️
routers/repo/attachment.go 40.67% <0%> (+30.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3a9c4c...8515138. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 10, 2019
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo nit. Otherwise LGTM.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 10, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 10, 2019
@lunny
Copy link
Member

lunny commented Dec 10, 2019

wait #9309 (comment)

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
@sapk
Copy link
Member Author

sapk commented Dec 10, 2019

@lunny done

@lunny lunny merged commit 4dc3993 into go-gitea:master Dec 10, 2019
@sapk sapk deleted the test-attachements branch December 10, 2019 11:40
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants