-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
tests: add attachement tests integration #9309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9309 +/- ##
==========================================
+ Coverage 41.17% 41.19% +0.02%
==========================================
Files 559 559
Lines 73101 73101
==========================================
+ Hits 30096 30116 +20
+ Misses 39235 39209 -26
- Partials 3770 3776 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo nit. Otherwise LGTM.
wait #9309 (comment) |
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
@lunny done |
Extracted from #7956, to make them work before changing (rebasing) anything.
I haven't very much time lately to do a rebase of the PR in one-shoot. I think this could be already merged as it add more test on current code and it will ease the review later when I rebase the PR with fix.