Fix bug in Issue.GetIsRead #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appleboy
approved these changes
Feb 9, 2017
|
LGTM |
tboerger
added
the
lgtm/need 1
lunny
reviewed
Feb 9, 2017
models/issue.go
Outdated
| @@ -193,7 +193,9 @@ func (issue *Issue) GetIsRead(userID int64) error { | |||
| if has, err := x.Get(issueUser); err != nil { | |||
| return err | |||
| } else if !has { | |||
| return ErrUserNotExist{UID: userID} | |||
| issue.IsRead = false | |||
| _, err := x.Insert(&IssueUser{IssueID: issue.ID, UID: userID}) | |||
There was a problem hiding this comment.
issue.IsRead = false
return nilI think that's enough.
ethantkoenig
force-pushed
the
issue_bug_fix
branch
from
f51b085
to
7c75000
Compare
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where a user would get a 500 if they tried to view the issues for a repo with issues they'd never viewed before.