Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicate queries in auth #827

Merged
merged 1 commit into from
Feb 5, 2017
Merged

Conversation

ethantkoenig
Copy link
Member

In the common case, two identical calls to GetUserByID(..) are made when SignedInUser(..) is called: one by SignedInID(..) (which SignedInUser(..) calls), and another by SignedInUser(..) itself.

I've refactored the code so that only at most one call to GetUserByID(..) is made. I also think it makes GetUserByID(..) a little more readable, since I was able to "get rid of" a long if statement.

Avoid identical making calls to GetUserByID(..) in SignedInUser(..)
@andreynering
Copy link
Contributor

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 4, 2017
@andreynering andreynering added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Feb 4, 2017
@andreynering andreynering added this to the 1.1.0 milestone Feb 4, 2017
@lunny
Copy link
Member

lunny commented Feb 5, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 5, 2017
@lunny lunny merged commit e86d935 into go-gitea:master Feb 5, 2017
@ethantkoenig ethantkoenig deleted the refactor/auth branch February 6, 2017 02:39
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants