Skip to content

Conversation

sapk
Copy link
Member

@sapk sapk commented Aug 28, 2019

@lafriks
Copy link
Member

lafriks commented Aug 28, 2019

Build fails

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 28, 2019
@guillep2k
Copy link
Member

Build fails

@lafriks @sapk I'm having the same problem in #7767 ;

Please run 'make vendor' and commit the result:
diff --git a/vendor/modules.txt b/vendor/modules.txt
index 020e50b98..ade08e5b4 100644
--- a/vendor/modules.txt
+++ b/vendor/modules.txt
@@ -400,7 +400,7 @@ golang.org/x/text/internal/language/compact
golang.org/x/text/internal/utf8internal
golang.org/x/text/runes
golang.org/x/text/internal/tag
-# google.golang.org/appengine v1.6.1
+# google.golang.org/appengine v1.6.2
google.golang.org/appengine/cloudsql
google.golang.org/appengine/urlfetch
google.golang.org/appengine/internal
make: *** [Makefile:192: test-vendor] Error 1

make vendor does not render any differences.

@sapk
Copy link
Member Author

sapk commented Aug 28, 2019

I had too much confidence on a simple git rebase over master 😄. I will redo the step in #8019 (comment) and should be good.

@sapk
Copy link
Member Author

sapk commented Aug 28, 2019

Or not

@guillep2k
Copy link
Member

Or not

@sapk I was about to tell you. That change is already merged and in my case, merging from it didn't help.

@sapk
Copy link
Member Author

sapk commented Aug 28, 2019

What is strange is that google.golang.org/appengine v1.6.2 is not referenced in any go.mod

@guillep2k
Copy link
Member

Perhaps this has something to do with it?

https://github.com/golang/appengine/releases

image

@sapk
Copy link
Member Author

sapk commented Aug 28, 2019

Yes but I cann't find a way to force the update on my machine...

@guillep2k
Copy link
Member

guillep2k commented Aug 28, 2019

It could be a replication delay problem. The drone must be seeing the latest version, while our development servers have outdated cached information.

@guillep2k
Copy link
Member

You know Google... they must have hundreds of copies of this server around the world. It's probably a matter of waiting a couple of hours.

@sapk
Copy link
Member Author

sapk commented Aug 28, 2019

Yes I try to set GOPROXY to the one from CI but with no luck. I updated manually the module.txt

@guillep2k
Copy link
Member

I'll try that myself.

@codecov-io
Copy link

Codecov Report

Merging #8021 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8021      +/-   ##
==========================================
- Coverage    41.6%   41.58%   -0.02%     
==========================================
  Files         479      479              
  Lines       64106    64106              
==========================================
- Hits        26669    26661       -8     
- Misses      33979    33988       +9     
+ Partials     3458     3457       -1
Impacted Files Coverage Δ
models/unit.go 62.16% <0%> (-5.41%) ⬇️
routers/repo/view.go 42.53% <0%> (-1.02%) ⬇️
models/repo_list.go 73.17% <0%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cedb285...b54741b. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 29, 2019
@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Aug 29, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 29, 2019
@lunny lunny merged commit 187ae10 into go-gitea:master Aug 29, 2019
@sapk sapk deleted the updt-goquery branch August 29, 2019 05:41
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants