Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropTableColumns sqlite implementation (#7710) #7765

Merged

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Aug 5, 2019

  • Fix dropTableColumns sqlite implementation
  • use droptables and its index dropping support in v78 and v85
  • golang-ci fixes
  • Add migration from gitea 1.3.3 for sqlite which reveals the droptables bug - thus showing this works

* Fix dropTableColumns sqlite implementation

* use droptables and its index dropping support in v78 and v85

* golang-ci fixes

* Add migration from gitea 1.3.3 for sqlite which reveals the droptables bug - thus showing this works
@zeripath zeripath added this to the 1.9.1 milestone Aug 5, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 5, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 6, 2019
@lafriks
Copy link
Member

lafriks commented Aug 6, 2019

Hi LG-TM, are you here? :)

@lafriks lafriks merged commit 1b5908f into go-gitea:release/v1.9 Aug 6, 2019
@zeripath zeripath deleted the backport-fix-droptablecolumns branch August 6, 2019 16:26
@lunny
Copy link
Member

lunny commented Aug 19, 2019

back port from #7710

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants