Skip to content

Added missing error checks in tests #7554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 23, 2019
Merged

Added missing error checks in tests #7554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e37c79a
Added missing error checks in tests
muesli Jul 21, 2019
4fae475
Merge branch 'master' into err-check-tests
lunny Jul 23, 2019
9ebe56c
Merge branch 'master' into err-check-tests
lunny Jul 23, 2019
ed6132b
Merge branch 'master' into err-check-tests
zeripath Jul 23, 2019
823dd29
Merge branch 'master' into err-check-tests
zeripath Jul 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions models/release_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ func TestRelease_MirrorDelete(t *testing.T) {
assert.True(t, ok)

count, err := GetReleaseCountByRepoID(mirror.ID, findOptions)
assert.NoError(t, err)
assert.EqualValues(t, initCount+1, count)

release, err := GetRelease(repo.ID, "v0.2")
Expand All @@ -149,5 +150,6 @@ func TestRelease_MirrorDelete(t *testing.T) {
assert.True(t, ok)

count, err = GetReleaseCountByRepoID(mirror.ID, findOptions)
assert.NoError(t, err)
assert.EqualValues(t, initCount, count)
}
1 change: 1 addition & 0 deletions models/repo_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ func TestUpdateRepositoryVisibilityChanged(t *testing.T) {

// Get sample repo and change visibility
repo, err := GetRepositoryByID(9)
assert.NoError(t, err)
repo.IsPrivate = true

// Update it
Expand Down
5 changes: 4 additions & 1 deletion modules/git/repo_commit_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,9 @@ func TestRepository_GetCommitBranches(t *testing.T) {
func TestGetTagCommitWithSignature(t *testing.T) {
bareRepo1Path := filepath.Join(testReposDir, "repo1_bare")
bareRepo1, err := OpenRepository(bareRepo1Path)
commit, err := bareRepo1.GetCommit("3ad28a9149a2864384548f3d17ed7f38014c9e8a")
assert.NoError(t, err)

commit, err := bareRepo1.GetCommit("3ad28a9149a2864384548f3d17ed7f38014c9e8a")
assert.NoError(t, err)
assert.NotNil(t, commit)
assert.NotNil(t, commit.Signature)
Expand All @@ -52,6 +53,8 @@ func TestGetTagCommitWithSignature(t *testing.T) {
func TestGetCommitWithBadCommitID(t *testing.T) {
bareRepo1Path := filepath.Join(testReposDir, "repo1_bare")
bareRepo1, err := OpenRepository(bareRepo1Path)
assert.NoError(t, err)

commit, err := bareRepo1.GetCommit("bad_branch")
assert.Nil(t, commit)
assert.Error(t, err)
Expand Down
1 change: 1 addition & 0 deletions modules/git/repo_stats_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ func TestRepository_GetCodeActivityStats(t *testing.T) {
assert.NoError(t, err)

timeFrom, err := time.Parse(time.RFC3339, "2016-01-01T00:00:00+00:00")
assert.NoError(t, err)

code, err := bareRepo1.GetCodeActivityStats(timeFrom, "")
assert.NoError(t, err)
Expand Down