Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitea own dark codemirror theme #7317

Merged
merged 2 commits into from
Jun 28, 2019
Merged

gitea own dark codemirror theme #7317

merged 2 commits into from
Jun 28, 2019

Conversation

Cherrg
Copy link
Contributor

@Cherrg Cherrg commented Jun 28, 2019 •
edited
Loading

fix #6573 (Editor in dark mode can't be seen)

feel free to modify the colors

old

grafik

examples - this PR

md (wiki editor)

grafik

css

grafik

js

grafik

selection

grafik

@Cherrg
modify dark codemirror theme
6863ee2 
fix go-gitea#6573

Signed-off-by: Michael Gnehr <michael@gnehr.de>
@techknowlogick techknowlogick added type/bug topic/ui Change the appearance of the Gitea UI labels Jun 28, 2019
@techknowlogick techknowlogick added this to the 1.9.0 milestone Jun 28, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 28, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 28, 2019
@Cherrg
add selection color
56c6bae 
Signed-off-by: Michael Gnehr <michael@gnehr.de>
@Cherrg
Copy link
Contributor Author

Cherrg commented Jun 28, 2019

added selection color

@codecov-io
Copy link

codecov-io commented Jun 28, 2019 •
edited
Loading

Codecov Report

Merging #7317 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7317      +/-   ##
==========================================
- Coverage   41.25%   41.24%   -0.01%     
==========================================
  Files         464      464              
  Lines       62867    62867              
==========================================
- Hits        25934    25929       -5     
- Misses      33541    33548       +7     
+ Partials     3392     3390       -2
Impacted Files Coverage Δ
models/unit.go 62.16% <0%> (-5.41%) ⬇️
routers/repo/view.go 42.23% <0%> (-1.02%) ⬇️
models/repo_list.go 72.08% <0%> (-1.02%) ⬇️
modules/log/file.go 77.62% <0%> (+2.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c0f2b9...56c6bae. Read the comment docs.

@lunny lunny merged commit 855ebbd into go-gitea:master Jun 28, 2019
@Cherrg Cherrg deleted the cm_dark_theme branch June 28, 2019 22:57
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@Cherrg @jeffliu27
gitea own dark codemirror theme (go-gitea#7317)
ed5b767 
* modify dark codemirror theme

fix go-gitea#6573

Signed-off-by: Michael Gnehr <michael@gnehr.de>

* add selection color

Signed-off-by: Michael Gnehr <michael@gnehr.de>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Editor in dark mode can't be seen
5 participants
@Cherrg @codecov-io @lunny @techknowlogick @GiteaBot