Skip to content

fix GCArgs load from ini #7156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2019
Merged

fix GCArgs load from ini #7156

merged 1 commit into from
Jun 8, 2019

Conversation

@lunny
Copy link
Member

@lunny lunny commented Jun 8, 2019

Should fix #5593

@lunny lunny added the type/bug label Jun 8, 2019
@lunny lunny added this to the 1.9.0 milestone Jun 8, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 8, 2019
@codecov-io
Copy link

codecov-io commented Jun 8, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@ca58eee). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7156   +/-   ##
=========================================
  Coverage          ?   41.64%           
=========================================
  Files             ?      447           
  Lines             ?    60888           
  Branches          ?        0           
=========================================
  Hits              ?    25354           
  Misses            ?    32245           
  Partials          ?     3289
Impacted Files Coverage Δ
modules/setting/git.go 52.17% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca58eee...ae98f25. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 8, 2019
@lunny lunny merged commit 6fb31a5 into go-gitea:master Jun 8, 2019
@lunny lunny deleted the lunny/fix_gcargs branch June 8, 2019 11:49
lunny added a commit to lunny/gitea that referenced this pull request Jun 8, 2019
@lunny
fix GCArgs load from ini (go-gitea#7156)
58cff2a
@lunny lunny mentioned this pull request Jun 8, 2019
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Jun 8, 2019
techknowlogick pushed a commit that referenced this pull request Jun 8, 2019
@lunny @techknowlogick
fix GCArgs load from ini (#7156) (#7157)
873acd8
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@lunny @jeffliu27
fix GCArgs load from ini (go-gitea#7156)
afd4477
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@appleboy appleboy appleboy approved these changes

@adelowo adelowo adelowo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.9.0

Development

Successfully merging this pull request may close these issues.

GC_ARGS maybe not loaded?

5 participants

@lunny @codecov-io @appleboy @adelowo @GiteaBot