Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect noreply email address as user #7133

Merged
merged 2 commits into from
Jun 6, 2019
Merged

Detect noreply email address as user #7133

merged 2 commits into from
Jun 6, 2019

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Jun 5, 2019 •
edited
Loading

Fixes #2457

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 5, 2019
@codecov-io
Copy link

codecov-io commented Jun 5, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@dadc03f). Click here to learn what that means.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7133   +/-   ##
=========================================
  Coverage          ?   41.59%           
=========================================
  Files             ?      446           
  Lines             ?    60873           
  Branches          ?        0           
=========================================
  Hits              ?    25318           
  Misses            ?    32270           
  Partials          ?     3285
Impacted Files Coverage Δ
models/user.go 51.06% <70%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dadc03f...8bfa72c. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 5, 2019
@lunny
Copy link
Member

lunny commented Jun 6, 2019

How this resolve that problem?

@zeripath
Copy link
Contributor Author

zeripath commented Jun 6, 2019

Because the commits that are "misauthored" are commits created using the editor functionality when you have keep email private set. In which case those commits will be authored with the above email address.

@zeripath zeripath added this to the 1.9.0 milestone Jun 6, 2019
@zeripath zeripath merged commit bd55f6f into go-gitea:master Jun 6, 2019
@zeripath zeripath deleted the detect-no-reply-email-address-as-user branch June 6, 2019 05:54
@lunny
Copy link
Member

lunny commented Jun 6, 2019

@zeripath please send back port to v1.8

zeripath added a commit to zeripath/gitea that referenced this pull request Jun 13, 2019
@zeripath
Detect noreply email address as user (go-gitea#7133)
40c529b
@zeripath zeripath mentioned this pull request Jun 13, 2019
Merged
techknowlogick pushed a commit that referenced this pull request Jun 13, 2019
@zeripath @techknowlogick
Detect noreply email address as user (#7133) (#7195)
76e8eec
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@zeripath @jeffliu27
Detect noreply email address as user (go-gitea#7133)
e2782a0
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser approved these changes

@mrsdizzie mrsdizzie mrsdizzie approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Wrong avatars for authors in Commits tab
6 participants
@zeripath @codecov-io @lunny @mrsdizzie @jolheiser @GiteaBot