Repository avatar fallback configuration

[saitho]

Follow up on #6986.

When no repository avatar was assigned an empty img tag is rendered in repository list.

This bugfix only shows the repository avatar in repository list when one was uploaded.

This PR adds a configurable fallback.

In Gitea config the owner can switch between the following option:

do not show avatar (default)
generate random avatar, similarly to user avatars
show default avatar image

Also the owner can configure which image should be used as default image. Per default it will point to a new image I added, which is a png version of the repository octicon that is currently used.

If the owner decides to use random avatars and later decides to show a default image instead, I've added a task to the admin panel that removes the randomly generated avatar files.

[richmahn]

👍

[codecov-io]

Codecov Report

Merging #7087 into master will decrease coverage by 0.03%.
The diff coverage is 13.11%.

@@            Coverage Diff             @@
##           master    #7087      +/-   ##
==========================================
- Coverage   41.56%   41.53%   -0.04%     
==========================================
  Files         446      446              
  Lines       60770    60825      +55     
==========================================
+ Hits        25262    25264       +2     
- Misses      32223    32278      +55     
+ Partials     3285     3283       -2

Impacted Files	Coverage Δ
routers/admin/admin.go	0% <0%> (ø)	⬆️
models/repo.go	48.36% <10.71%> (-1.19%)	⬇️
modules/setting/setting.go	48.33% <100%> (+0.18%)	⬆️
models/unit.go	62.16% <0%> (-5.41%)	⬇️
routers/repo/view.go	42.02% <0%> (-1.02%)	⬇️
modules/log/file.go	77.62% <0%> (+2.09%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 356854f...d558ecf. Read the comment docs.

[lunny]

Hide or use a default image?

[techknowlogick]

I think default image is best

[saitho]

I've implemented a fallback configuration for missing repository avatars.
In Gitea config the owner can switch between the following option:

1. do not show avatar (default)
2. generate random avatar, similarly to user avatars
3. show default avatar image

Also the owner can configure which image should be used as default image. Per default it will point to a new image I added, which is a png version of the repository octicon that is currently used.

If the owner decides to use random avatars and later decides to show a default image instead, I've added a task to the admin panel that removes the randomly generated avatar files.

[lunny]

Why we need to remove the random avatars?

[saitho]

Random avatars are placed on the file system and set in the database.

Let's say an owner used generated repository avatars and now wants to display a default avatar instead. The generated avatars are stored just like uploaded avatars on the file system (the only difference is the file name) and also update the repository in the database.
The default avatar will be used when no image was added to the repository, which is why the randomly generated images will still be used instead of the default avatar.

[lunny]

When a repository has a random avatar, delete it from UI will make it as default image and upload a new avatar will delete the previous image. So I think the cron task is unnecessary?

[saitho]

True. But still, looking at an organization with 100 repositories an admin would have to through all projects and delete the avatars. That's why I wanted to provide an easy way to do so, which is why I placed it in the administration panel.
It's not supposed to be a cron task that is executed regularly. Maybe it would be better to put that into a cmd task like gitea cleanup repository-avatars...

[lunny]

Otherwise LGTM

[zeripath]

Fixes #7099