-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle early git version's lack of get-url #7065
Merged
zeripath
merged 2 commits into
go-gitea:master
from
zeripath:handle-old-git-for-git-remote-get-url-fixes-#6930
May 29, 2019
Merged
Handle early git version's lack of get-url #7065
zeripath
merged 2 commits into
go-gitea:master
from
zeripath:handle-old-git-for-git-remote-get-url-fixes-#6930
May 29, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeripath
added
backport/v1.8
issue/regression
Issue needs no code to be fixed, only a description on how to fix it yourself
labels
May 28, 2019
Codecov Report
@@ Coverage Diff @@
## master #7065 +/- ##
=========================================
Coverage ? 41.42%
=========================================
Files ? 442
Lines ? 59701
Branches ? 0
=========================================
Hits ? 24731
Misses ? 31733
Partials ? 3237
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
May 28, 2019
lafriks
approved these changes
May 28, 2019
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
May 28, 2019
lunny
approved these changes
May 29, 2019
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
May 29, 2019
Please backporr |
techknowlogick
added
the
backport/done
All backports for this PR have been created
label
May 29, 2019
techknowlogick
added a commit
that referenced
this pull request
May 29, 2019
7 tasks
jeffliu27
pushed a commit
to jeffliu27/gitea
that referenced
this pull request
Jul 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
issue/regression
Issue needs no code to be fixed, only a description on how to fix it yourself
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old versions of git do not have
git remote get-url
in which case we can usegit config --get remote.<name>.url
- however, please note that this is not a complete replacement for this as it will not handle insteadOf configuration. I do not think it is reasonable however to completely replicate this functionality and if users require that they should upgrade.Fix #6930