Install page - Handle invalid administrator username better #7060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techknowlogick
approved these changes
May 27, 2019
GiteaBot
added
the
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #7060 +/- ##
==========================================
- Coverage 41.45% 41.43% -0.02%
==========================================
Files 442 442
Lines 59623 59643 +20
==========================================
Hits 24716 24716
- Misses 31676 31696 +20
Partials 3231 3231
Continue to review full report at Codecov.
|
lunny
approved these changes
May 28, 2019
GiteaBot
added
lgtm/done
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
May 28, 2019
…#7060) * Install page - detect invalid admin username before installing * Also fix go-gitea#6954
zeripath
added a commit
that referenced
this pull request
May 28, 2019
jeffliu27
pushed a commit
to jeffliu27/gitea
that referenced
this pull request
Jul 18, 2019
…#7060) * Install page - detect invalid admin username before installing * Also fix go-gitea#6954
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1409
Fixes #6954
Detecting if the administrator username is invalid before creating the initial config and global init means that the user can change this - previously this would cause an unending loop.
It also checks the email is not empty.