Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for posting single comments in split diff view #7052

Merged
merged 2 commits into from
May 29, 2019
Merged

Workaround for posting single comments in split diff view #7052

merged 2 commits into from
May 29, 2019

Conversation

rfwatson
Copy link
Contributor

Workaround for #4745.

  • This doesn't fix the root cause, which is that the .add-code-comment div is somehow obscuring the Post single comment button and hijacking the click events
  • Changing the button's z-index doesn't seem to have an effect
  • It's not clear why the other buttons on the same form aren't affected 🤷‍♂️

Signed-off-by: Rob Watson <rfwatson@users.noreply.github.com>
@rfwatson
Copy link
Contributor Author

Not sure why the CI is failing

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 26, 2019
@lunny
Copy link
Member

lunny commented May 26, 2019

It's unrelated, restarted.

@codecov-io
Copy link

Codecov Report

Merging #7052 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7052      +/-   ##
==========================================
+ Coverage   41.44%   41.45%   +0.01%     
==========================================
  Files         442      442              
  Lines       59604    59608       +4     
==========================================
+ Hits        24702    24713      +11     
+ Misses      31672    31664       -8     
- Partials     3230     3231       +1
Impacted Files Coverage Δ
models/models.go 57.5% <0%> (+0.72%) ⬆️
routers/repo/view.go 43.03% <0%> (+1.01%) ⬆️
modules/log/colors_router.go 87.5% <0%> (+4.16%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 063fa99...4da487b. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 29, 2019
@lafriks lafriks added this to the 1.9.0 milestone May 29, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 29, 2019
@zeripath
Copy link
Contributor

Make lg-tm work

@zeripath zeripath merged commit d749404 into go-gitea:master May 29, 2019
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
…tea#7052)

Signed-off-by: Rob Watson <rfwatson@users.noreply.github.com>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants