Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix charset was not saved after installation finished #7048

Merged
merged 4 commits into from
May 26, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented May 26, 2019

On #6992, we introduced CHARSET on database seciton to app.ini. But unfortunately, I missed to save CHARSET to app.ini after installation finished. This PR will fix that.

@lunny lunny added the type/bug label May 26, 2019
@lunny lunny added this to the 1.9.0 milestone May 26, 2019
@codecov-io
Copy link

codecov-io commented May 26, 2019

Codecov Report

Merging #7048 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7048      +/-   ##
==========================================
+ Coverage   41.45%   41.45%   +<.01%     
==========================================
  Files         442      442              
  Lines       59608    59610       +2     
==========================================
+ Hits        24708    24709       +1     
- Misses      31670    31672       +2     
+ Partials     3230     3229       -1
Impacted Files Coverage Δ
routers/install.go 0% <0%> (ø) ⬆️
models/repo_list.go 72.08% <0%> (-1.02%) ⬇️
models/gpg_key.go 56.66% <0%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3d87da...ad3f597. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 26, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 26, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 26, 2019
@techknowlogick techknowlogick merged commit d67fd69 into go-gitea:master May 26, 2019
@lunny lunny deleted the lunny/fix_install_chaset branch June 10, 2019 11:47
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants