Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Align comment label and actions to the right #7024

Merged
merged 6 commits into from
May 25, 2019
Merged

Bugfix: Align comment label and actions to the right #7024

merged 6 commits into from
May 25, 2019

Conversation

saitho
Copy link
Contributor

@saitho saitho commented May 23, 2019 •
edited
Loading

Just noticed that the class "right" set for the comment label and actions is not applied correctly.
That is because of the wrapping flexbox. This fix aligns the comment label (if it has one) and the actions (edit, delete) to the right via flexbox.

That's how it will look like:
screen

@saitho
Bugfix: Align comment label and actions to the right
6fe8757 
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label May 23, 2019
@lafriks lafriks added this to the 1.9.0 milestone May 23, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 23, 2019
@techknowlogick
Copy link
Member

Are you able to provide a screenshot of what it looks like after your changes have been applied?

@codecov-io
Copy link

codecov-io commented May 23, 2019 •
edited
Loading

Codecov Report

Merging #7024 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7024      +/-   ##
==========================================
- Coverage   41.49%   41.48%   -0.01%     
==========================================
  Files         441      441              
  Lines       59526    59526              
==========================================
- Hits        24700    24695       -5     
- Misses      31598    31604       +6     
+ Partials     3228     3227       -1
Impacted Files Coverage Δ
models/unit.go 62.16% <0%> (-5.41%) ⬇️
routers/repo/view.go 42.02% <0%> (-1.02%) ⬇️
models/gpg_key.go 55.83% <0%> (-0.84%) ⬇️
modules/log/file.go 77.62% <0%> (+2.09%) ⬆️
modules/log/colors_router.go 87.5% <0%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df25578...61360cc. Read the comment docs.

@saitho
Copy link
Contributor Author

saitho commented May 24, 2019

Are you able to provide a screenshot of what it looks like after your changes have been applied?

That's the screenshot at the top. :)

@lafriks
Copy link
Member

lafriks commented May 24, 2019

Is screenshot fixed version? If so that bubble kind of thingy is way off, it should be to the right form user avatar not left

lafriks
lafriks requested changes May 24, 2019
View reviewed changes
Copy link
Member

@lafriks lafriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my previous comment

@saitho
Copy link
Contributor Author

saitho commented May 24, 2019

Ah, right. Shouldn't have removed position: relative; in header. :D

@lafriks
Copy link
Member

lafriks commented May 24, 2019

Can you update screenshot?

@saitho
Copy link
Contributor Author

saitho commented May 24, 2019

Updated

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 24, 2019
@lafriks lafriks merged commit 0c432d2 into go-gitea:master May 25, 2019
@saitho saitho deleted the bugfix/align-comment-label-actions branch May 25, 2019 21:38
@lunny lunny mentioned this pull request May 26, 2019
Closed
lunny added a commit that referenced this pull request May 26, 2019
@lunny
Revert "Bugfix: Align comment label and actions to the right (#7024)"
15423de 
This reverts commit 0c432d2.
@lunny lunny mentioned this pull request May 26, 2019
Merged
techknowlogick pushed a commit that referenced this pull request May 26, 2019
@lunny @techknowlogick
Revert "Bugfix: Align comment label and actions to the right (#7024)" (…
f3d87da 
…#7055)

This reverts commit 0c432d2.
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@saitho @jeffliu27
Bugfix: Align comment label and actions to the right (go-gitea#7024)
0f1bb60 
* Bugfix: Align comment label and actions to the right

Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>

* Restores relative position

* CSS autofixer
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@lunny @jeffliu27
Revert "Bugfix: Align comment label and actions to the right (go-gite…
fec58ac 
…a#7024)" (go-gitea#7055)

This reverts commit 0c432d2.
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@adelowo adelowo adelowo approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
6 participants
@saitho @techknowlogick @codecov-io @lafriks @adelowo @GiteaBot