-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LFS Locks over SSH #6999
Fix LFS Locks over SSH #6999
Conversation
It seems there is an issue reported that. |
@lunny do you know which issue it is because I can't seem to easily find it. |
Maybe it is #5478 |
Codecov Report
@@ Coverage Diff @@
## master #6999 +/- ##
=========================================
Coverage ? 41.43%
=========================================
Files ? 442
Lines ? 59693
Branches ? 0
=========================================
Hits ? 24731
Misses ? 31725
Partials ? 3237
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to use the Skip method in place of simple return in skipped tests. Overall looks good but I haven't tested yet.
@sapk have you been able to test this yet? git_test.go does test the locking now btw. |
@zeripath not much time to do so lately. So if someone other validate it should be good as my requested changes are done. |
* Fix LFS Locks over SSH * Mark test as skipped
* Fix LFS Locks over SSH * Mark test as skipped
Whilst looking at adding more tests for #6993 I've noticed that LFS locking was not-preauthenticating correctly over SSH.
This PR fixes this.
Fixes #3084