Skip to content

Style orgs list in user profile #6911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2019
Merged

Conversation

xf-
Copy link
Contributor

@xf- xf- commented May 11, 2019

Change:
Add a wrapper to organization list to target it with css selector, remove fixed size. Add CSS for organization list.
I use important because some really heavy large selector setting some options.

Current state:
The organization list has whitespaces instead of padding and no space to second row

@xf- xf- force-pushed the task/orglistUser branch from 3199d57 to 0948313 Compare May 11, 2019 19:12
@xf-
Copy link
Contributor Author

xf- commented May 11, 2019

Added -3px margin to remove the padding on borders or the list.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 11, 2019
@codecov-io
Copy link

codecov-io commented May 11, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@ce8de35). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6911   +/-   ##
=========================================
  Coverage          ?   41.42%           
=========================================
  Files             ?      440           
  Lines             ?    59738           
  Branches          ?        0           
=========================================
  Hits              ?    24745           
  Misses            ?    31757           
  Partials          ?     3236

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce8de35...0948313. Read the comment docs.

@lafriks
Copy link
Member

lafriks commented May 11, 2019

Screenshot old vs new?

@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label May 11, 2019
Copy link
Member

@kolaente kolaente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could you add some screenshots? (From the whole org page would be great)

@xf-
Copy link
Contributor Author

xf- commented May 11, 2019

@lafriks my screenshots are gone in PR Oo i send some in discord
current state with selected text node as spacer
image

@kolaente yes. any specific breakpoints, sizes?
Fullscreen Firefox screenshot
image

@lunny lunny added this to the 1.9.0 milestone May 12, 2019
@xf- xf- force-pushed the task/orglistUser branch from 0948313 to 5c43abf Compare May 13, 2019 19:45
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 13, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 13, 2019
@lafriks lafriks merged commit 597ac06 into go-gitea:master May 13, 2019
@xf- xf- deleted the task/orglistUser branch May 13, 2019 21:13
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants