Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config ui error about cache ttl #6861

Merged
merged 1 commit into from
May 6, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented May 6, 2019

Will fix #6730 and replace #6770. @adelowo

@lunny lunny added the topic/ui Change the appearance of the Gitea UI label May 6, 2019
@lunny lunny added this to the 1.9.0 milestone May 6, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 6, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@5d5eae6). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6861   +/-   ##
=========================================
  Coverage          ?   41.18%           
=========================================
  Files             ?      425           
  Lines             ?    58490           
  Branches          ?        0           
=========================================
  Hits              ?    24089           
  Misses            ?    31214           
  Partials          ?     3187
Impacted Files Coverage Δ
routers/admin/admin.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d5eae6...4f65f10. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 6, 2019
@lafriks lafriks merged commit 01ebd52 into go-gitea:master May 6, 2019
@lunny lunny deleted the lunny/fix_config_ui branch May 6, 2019 15:41
lunny added a commit to lunny/gitea that referenced this pull request May 6, 2019
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label May 6, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redis cache configuration always got Cache Interval 0 seconds
6 participants