Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v85.go #6851

Merged
merged 1 commit into from
May 5, 2019
Merged

Fix v85.go #6851

merged 1 commit into from
May 5, 2019

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented May 5, 2019

In trying to create migration tests for MSSQL I've noticed that the v85 sets the UNIQUE constraint too early.

This PR fixes this by asserting the creation of the UNIQUE index later.

Signed-off-by: Andrew Thornton art27@cantab.net

Signed-off-by: Andrew Thornton <art27@cantab.net>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 5, 2019
@codecov-io
Copy link

Codecov Report

Merging #6851 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6851      +/-   ##
==========================================
- Coverage   41.18%   41.17%   -0.02%     
==========================================
  Files         423      423              
  Lines       58399    58416      +17     
==========================================
- Hits        24052    24051       -1     
- Misses      31169    31185      +16     
- Partials     3178     3180       +2
Impacted Files Coverage Δ
models/migrations/v85.go 0% <0%> (ø) ⬆️
modules/log/file.go 75.52% <0%> (-2.1%) ⬇️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d27bf72...d9d5a27. Read the comment docs.

@lunny lunny added the type/bug label May 5, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 5, 2019
@lunny lunny added this to the 1.9.0 milestone May 5, 2019
@zeripath zeripath merged commit 07bcccf into go-gitea:master May 5, 2019
@zeripath zeripath deleted the fix-v85-migration branch May 5, 2019 13:47
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants