Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change verbose flag in dump command to avoid colliding with global version flag #6822

Merged
merged 2 commits into from
May 1, 2019

Conversation

jolheiser
Copy link
Member

As title

Fixes #6821

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@techknowlogick techknowlogick added this to the 1.9.0 milestone May 1, 2019
@techknowlogick
Copy link
Member

Can you update docs as well?

Does this need to be backported?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 1, 2019
@jolheiser
Copy link
Member Author

No need to backport since it was introduced with #6631 which is new to 1.9

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser
Copy link
Member Author

@techknowlogick Done, I did a quick search and only found it referenced once in docs. If someone knows of another place let me know, but searching for verbose and -v I could only see this one spot.

Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 1, 2019
@codecov-io
Copy link

codecov-io commented May 1, 2019

Codecov Report

Merging #6822 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6822      +/-   ##
==========================================
+ Coverage   41.21%   41.21%   +<.01%     
==========================================
  Files         421      421              
  Lines       58118    58118              
==========================================
+ Hits        23951    23956       +5     
+ Misses      30994    30990       -4     
+ Partials     3173     3172       -1
Impacted Files Coverage Δ
models/repo_list.go 66.84% <0%> (-1.06%) ⬇️
routers/repo/view.go 43.03% <0%> (+1.01%) ⬆️
modules/log/file.go 77.62% <0%> (+2.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caba282...282c965. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 1, 2019
@zeripath zeripath merged commit e255df8 into go-gitea:master May 1, 2019
@zeripath
Copy link
Contributor

zeripath commented May 1, 2019

Sorry peeps for introducing that bug!

@jolheiser jolheiser deleted the 6821_verbose branch May 1, 2019 20:36
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backup (dump) command fails with stacktrace - latest tag on dockerhub (1.7.6 works fine)
5 participants