LDAP: ignore already existing public keys after ldap sync #6766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y import if existing Signed-off-by: Lukas Prettenthaler <lukas@noenv.com>
Signed-off-by: Lukas Prettenthaler <lukas@noenv.com>
lafriks
requested changes
Apr 26, 2019
GiteaBot
added
the
lgtm/need 2
lafriks
added
type/enhancement
Signed-off-by: Lukas Prettenthaler <lukas@noenv.com>
Signed-off-by: Lukas Prettenthaler <lukas@noenv.com>
zeripath
approved these changes
Apr 26, 2019
GiteaBot
added
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #6766 +/- ##
==========================================
+ Coverage 40.99% 40.99% +<.01%
==========================================
Files 421 421
Lines 58050 58054 +4
==========================================
+ Hits 23797 23802 +5
+ Misses 31086 31085 -1
Partials 3167 3167
Continue to review full report at Codecov.
|
adelowo
approved these changes
Apr 26, 2019
GiteaBot
added
lgtm/done
lafriks
approved these changes
Apr 26, 2019
mrsdizzie
approved these changes
Apr 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log at Trace level only on ErrKeyAlreadyExist - instead of at Error level.
Fix typo in ErrKeyAlreadyExist Error string.