Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix new team 500 #6749

Merged
merged 2 commits into from
Apr 25, 2019
Merged

fix new team 500 #6749

merged 2 commits into from
Apr 25, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 25, 2019

will fix #6728

@lunny lunny added this to the 1.9.0 milestone Apr 25, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 25, 2019
@lafriks @lunny
Update models/unit.go
c48d71a 
Co-Authored-By: lunny <xiaolunwen@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #6749 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6749      +/-   ##
==========================================
- Coverage   40.97%   40.97%   -0.01%     
==========================================
  Files         421      421              
  Lines       57931    57933       +2     
==========================================
- Hits        23739    23738       -1     
- Misses      31033    31035       +2     
- Partials     3159     3160       +1
Impacted Files Coverage Δ
models/unit.go 43.24% <0%> (-2.48%) ⬇️
modules/log/file.go 75.52% <0%> (-2.1%) ⬇️
models/repo_list.go 67.89% <0%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dabee9b...c48d71a. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 25, 2019
@lunny lunny merged commit 65b3f51 into go-gitea:master Apr 25, 2019
@lunny lunny deleted the lunny/fix_team_new branch April 25, 2019 09:00
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@adelowo adelowo adelowo approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

teams/new => error
5 participants
@lunny @codecov-io @lafriks @adelowo @GiteaBot