Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix admin template error #6737

Merged
merged 1 commit into from
Apr 24, 2019
Merged

fix admin template error #6737

merged 1 commit into from
Apr 24, 2019

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Apr 24, 2019

Fixes #6732

@codecov-io
Copy link

Codecov Report

Merging #6737 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6737      +/-   ##
==========================================
+ Coverage   40.73%   40.75%   +0.01%     
==========================================
  Files         421      421              
  Lines       57902    57902              
==========================================
+ Hits        23588    23596       +8     
+ Misses      31179    31172       -7     
+ Partials     3135     3134       -1
Impacted Files Coverage Δ
models/gpg_key.go 54.72% <0%> (+0.83%) ⬆️
models/repo_list.go 67.89% <0%> (+1.05%) ⬆️
modules/log/event.go 65.98% <0%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59be704...f1140cd. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 24, 2019
@lunny lunny added the type/bug label Apr 24, 2019
@lunny lunny added this to the 1.9.0 milestone Apr 24, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 24, 2019
@lunny
Copy link
Member

lunny commented Apr 24, 2019

Thanks!

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 24, 2019
@lunny lunny merged commit 08d8ea9 into go-gitea:master Apr 24, 2019
@adelowo adelowo deleted the fix_6732 branch April 24, 2019 15:39
@xf-
Copy link
Contributor

xf- commented May 4, 2019

@lunny maybe backport to 1.8 - Page is not working. Not really nice for a new admin if system notifications are broken

@adelowo
Copy link
Member Author

adelowo commented May 4, 2019

I cannot replicate this on 1.8

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
6 participants
@adelowo @codecov-io @lunny @xf- @zeripath @GiteaBot