Skip to content

Drop is_bare IDX only when it exists for MySQL and MariaDB #6736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 24, 2019
Merged

Drop is_bare IDX only when it exists for MySQL and MariaDB #6736

merged 4 commits into from
Apr 24, 2019

Conversation

@adelowo
Copy link
Member

@adelowo adelowo commented Apr 24, 2019 •
edited
Loading

@lafriks lafriks added this to the 1.9.0 milestone Apr 24, 2019
lafriks
lafriks requested changes Apr 24, 2019
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 24, 2019
@codecov-io
Copy link

codecov-io commented Apr 24, 2019 •
edited
Loading

Codecov Report

Merging #6736 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6736      +/-   ##
=========================================
- Coverage   40.82%   40.8%   -0.02%     
=========================================
  Files         421     421              
  Lines       57902   57910       +8     
=========================================
- Hits        23640   23633       -7     
- Misses      31123   31139      +16     
+ Partials     3139    3138       -1
Impacted Files Coverage Δ
models/migrations/v78.go 0% <0%> (ø) ⬆️
models/unit.go 45.71% <0%> (-5.72%) ⬇️
modules/log/event.go 64.46% <0%> (-1.53%) ⬇️
routers/repo/view.go 41.6% <0%> (-1.01%) ⬇️
models/repo_list.go 67.89% <0%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d8b521...cca25e3. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 24, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 24, 2019
@lafriks lafriks merged commit 821184c into go-gitea:master Apr 24, 2019
@lafriks
Copy link
Member

lafriks commented Apr 24, 2019

please backport to release/v1.8

@adelowo adelowo deleted the fix_migration_78 branch April 24, 2019 17:52
adelowo added a commit to adelowo/gitea that referenced this pull request Apr 24, 2019
@adelowo
Drop is_bare IDX only when it exists for MySQL and MariaDB (go-gitea#…
cf57744 
…6736)

* Drop is_bare IDX only when it exists

* show indexes only on mysql or mariadb
@adelowo adelowo mentioned this pull request Apr 24, 2019
Merged
zeripath pushed a commit that referenced this pull request Apr 24, 2019
@adelowo @zeripath
Drop is_bare IDX only when it exists for MySQL and MariaDB (#6736) (#…
26c1550 
…6744)

* Drop is_bare IDX only when it exists

* show indexes only on mysql or mariadb
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.9.0

Development

Successfully merging this pull request may close these issues.

Migration failure 1.7.6->1.8.0: No such index: IDX_user_"idx_user_IDX_user_is_active"

5 participants

@adelowo @codecov-io @lafriks @zeripath @GiteaBot