Unfortunately MemProvider Init does not actually Init properly #6692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Worse all of its members are private and you cannot update them. Simple fix copy it in to modules session. Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
type/bug
issue/regression
|
thx for fast fix :D |
GiteaBot
added
the
lgtm/need 2
Codecov Report
@@ Coverage Diff @@
## master #6692 +/- ##
=========================================
- Coverage 40.88% 40.79% -0.1%
=========================================
Files 420 421 +1
Lines 57453 57570 +117
=========================================
- Hits 23490 23485 -5
- Misses 30837 30959 +122
Partials 3126 3126
Continue to review full report at Codecov.
|
lunny
approved these changes
Apr 20, 2019
GiteaBot
added
lgtm/need 1
adelowo
approved these changes
Apr 20, 2019
GiteaBot
added
lgtm/done
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Apr 20, 2019
…tea#6692) * Unfortunately MemProvider Init does not actually Init properly Worse all of its members are private and you cannot update them. Simple fix copy it in to modules session. Signed-off-by: Andrew Thornton <art27@cantab.net> * Fix misspelling
zeripath
added a commit
that referenced
this pull request
Apr 20, 2019
#6693) * Unfortunately MemProvider Init does not actually Init properly Worse all of its members are private and you cannot update them. Simple fix copy it in to modules session. Signed-off-by: Andrew Thornton <art27@cantab.net> * Fix misspelling
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worse all of its members are private and you cannot update them.
Simple fix copy it in to modules session.
Fix #6691
Not sure why our tests didn't catch this.
Signed-off-by: Andrew Thornton art27@cantab.net