Fix forking an empty repository #6637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes go-gitea#6633 Signed-off-by: Segev Finer <segev@codeocean.com>
Codecov Report
@@ Coverage Diff @@
## master #6637 +/- ##
==========================================
+ Coverage 40.53% 40.53% +<.01%
==========================================
Files 406 406
Lines 54492 54494 +2
==========================================
+ Hits 22086 22088 +2
Misses 29370 29370
Partials 3036 3036
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
zeripath
approved these changes
Apr 15, 2019
GiteaBot
added
lgtm/need 1
jonasfranz
approved these changes
Apr 15, 2019
GiteaBot
added
lgtm/done
|
This should be back port to v1.8 |
segevfiner
added a commit
to codeocean/gitea
that referenced
this pull request
Apr 16, 2019
Fixes go-gitea#6633 Signed-off-by: Segev Finer <segev@codeocean.com>
techknowlogick
added
the
backport/done
zeripath
pushed a commit
that referenced
this pull request
Apr 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forking an empty repo didn't copy the
IsEmptyflag which lead to Git errors, and once we did copy it, therepoAssignmentmiddleware didn't populateBaseRepowhich lead to anilerror from the templates.Fixes #6633 (Assuming there aren't issues in other places)
cc @shay-k