fix issuer of OTP URI should be URI-encoded.

[huihuimoe]

I noticed that the URI of gitea totp 2fa would be failed parsed in some OTP parse libs.

Original URI like this

otpauth://totp/%E5%96%B5%20%E3%81%A8%20Nyaa%20%28https://old.huihui.cat%29:user?algorithm=SHA1&digits=6&issuer=%E5%96%B5+%E3%81%A8+Nyaa+%28https%3A%2F%2Fold.huihui.cat%29&period=30&secret=WHY5IXDH5S73SGA5

: appeared twice and other programs could parse the incorrect issuer here.

Following Google's OTP URI Format,

The label is used to identify which account a key is associated with. It contains an account name, which is a URI-encoded string, optionally prefixed by an issuer string identifying the provider or service managing that account.

[codecov-io]

Codecov Report

Merging #6634 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #6634      +/-   ##
==========================================
- Coverage   41.45%   41.44%   -0.01%     
==========================================
  Files         442      442              
  Lines       59610    59611       +1     
==========================================
- Hits        24712    24708       -4     
- Misses      31667    31673       +6     
+ Partials     3231     3230       -1

Impacted Files	Coverage Δ
routers/user/setting/security_twofa.go	18.38% <100%> (+0.6%)	⬆️
models/unit.go	62.16% <0%> (-5.41%)	⬇️
routers/repo/view.go	42.02% <0%> (-1.02%)	⬇️
modules/log/colors_router.go	87.5% <0%> (+4.16%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c412f5...9f62295. Read the comment docs.

[zeripath]

Could you give an example of an otp library that doesn't work?

[zeripath]

OK how do we fix this? I think we need to make this issuer label configurable and put a warning in the documentation somewhere that the default may not work on older otp parsing libraries.

[huihuimoe]

examples:

• https://github.com/hectorm/otpauth

OTPAuth.URI.parse("otpauth://totp/%E5%96%B5%20%E3%81%A8%20Nyaa%20%28https://old.huihui.cat%29:user?algorithm=SHA1&digits=6&issuer=%E5%96%B5+%E3%81%A8+Nyaa+%28https%3A%2F%2Fold.huihui.cat%29&period=30&secret=WHY5IXDH5S73SGA5")

Uncaught TypeError: Invalid 'issuer' parameter
    at Function.q.parse (<anonymous>:43:253)
    at <anonymous>:1:13

• https://github.com/lvillani/url-otpauth

parse("otpauth://totp/%E5%96%B5%20%E3%81%A8%20Nyaa%20%28https://old.huihui.cat%29:user?algorithm=SHA1&digits=6&issuer=%E5%96%B5+%E3%81%A8+Nyaa+%28https%3A%2F%2Fold.huihui.cat%29&period=30&secret=WHY5IXDH5S73SGA5")

Uncaught n {name: "OtpauthInvalidURL", message: "Given otpauth:// URL is invalid. (Error 1)", errorType: 1}