Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra slash from twitter card #6619

Merged
merged 2 commits into from
Apr 14, 2019
Merged

Remove extra slash from twitter card #6619

merged 2 commits into from
Apr 14, 2019

Conversation

techknowlogick
Copy link
Member

on try.gitea.io the current looks like: <meta property="og:image" content="https://try.gitea.io//img/gitea-lg.png" />

This PR removes the extra slash from the AppUrl

cc: @ashimokawa

@techknowlogick techknowlogick added this to the 1.9.0 milestone Apr 14, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 14, 2019
@codecov-io
Copy link

codecov-io commented Apr 14, 2019

Codecov Report

Merging #6619 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6619      +/-   ##
==========================================
+ Coverage   40.46%   40.47%   +0.01%     
==========================================
  Files         406      406              
  Lines       54484    54484              
==========================================
+ Hits        22045    22052       +7     
+ Misses      29402    29395       -7     
  Partials     3037     3037
Impacted Files Coverage Δ
routers/repo/view.go 42.07% <0%> (+0.99%) ⬆️
modules/log/event.go 65.98% <0%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77ffb15...81823ad. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 14, 2019
@techknowlogick techknowlogick merged commit e6161b0 into go-gitea:master Apr 14, 2019
@techknowlogick techknowlogick deleted the techknowlogick-patch-3 branch April 14, 2019 22:04
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants