Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SUBJECT_PREFIX mailer config option #6605

Merged
merged 4 commits into from
Apr 17, 2019

Conversation

zeripath
Copy link
Contributor

Since the split Gogs has added a SUBJECT_PREFIX option to the mailer config. This PR implements this option.

Fix #6574

@zeripath zeripath added this to the 1.9.0 milestone Apr 13, 2019
@zeripath zeripath added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Apr 13, 2019
@codecov-io
Copy link

codecov-io commented Apr 13, 2019

Codecov Report

Merging #6605 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6605      +/-   ##
==========================================
- Coverage   40.55%   40.55%   -0.01%     
==========================================
  Files         406      406              
  Lines       54501    54506       +5     
==========================================
+ Hits        22102    22104       +2     
  Misses      29364    29364              
- Partials     3035     3038       +3
Impacted Files Coverage Δ
modules/setting/mailer.go 50.7% <100%> (+0.7%) ⬆️
modules/mailer/mailer.go 22.51% <40%> (+0.05%) ⬆️
models/repo_list.go 66.84% <0%> (-1.06%) ⬇️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84fd242...f9d8287. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 13, 2019
custom/conf/app.ini.sample Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 16, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 17, 2019
@techknowlogick techknowlogick merged commit 827ab6b into go-gitea:master Apr 17, 2019
@zeripath zeripath deleted the fix-6574-Subject-Prefix branch April 22, 2019 20:22
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What's the equivalent of GOGS mailer SUBJECT_PREFIX
6 participants