Context.ServerError and NotFound should log from their caller #6550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolheiser
approved these changes
Apr 9, 2019
GiteaBot
added
the
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #6550 +/- ##
==========================================
+ Coverage 40.35% 40.36% +<.01%
==========================================
Files 405 405
Lines 54251 54255 +4
==========================================
+ Hits 21892 21899 +7
+ Misses 29343 29340 -3
Partials 3016 3016
Continue to review full report at Codecov.
|
lafriks
approved these changes
Apr 9, 2019
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Context.ServerError and NotFound log, they can mask the true location of the error by setting their skip too low. This PR makes their log calls appear as if they're coming from their caller. This will seriously help debugging.