[docker] drop the bits argument when generating an ed25519 key #6504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the man page of ssh-keygen: Ed25519 keys have a fixed length and the -b flag will be ignored. [skip ci] Signed-off-by: Jakob Ackermann <das7pad@outlook.com>
Codecov Report
@@ Coverage Diff @@
## master #6504 +/- ##
==========================================
- Coverage 40.27% 40.27% -0.01%
==========================================
Files 403 403
Lines 54068 54068
==========================================
- Hits 21775 21774 -1
- Misses 29276 29277 +1
Partials 3017 3017
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
sapk
approved these changes
Apr 3, 2019
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Apr 4, 2019
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the man page of ssh-keygen [1]:
The actual private key size for Ed25519 is 256 bits [1] which does not match with the currently specified 4096 bits anyways.
[1] https://man.openbsd.org/ssh-keygen#b
[2] https://tools.ietf.org/html/rfc8032#section-5.1.5