-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for client basic auth for exchanging access tokens #6293
Conversation
Test seems to fail with empty client id |
Codecov Report
@@ Coverage Diff @@
## master #6293 +/- ##
=========================================
Coverage ? 38.87%
=========================================
Files ? 358
Lines ? 51038
Branches ? 0
=========================================
Hits ? 19839
Misses ? 28329
Partials ? 2870
Continue to review full report at Codecov.
|
@jonasfranz / @zeripath
|
Just a note for whoever looks at this, since I don't know enough about Xorm's backend. gitea/models/oauth2_application.go Lines 43 to 46 in e777c6b
|
That's not caused by this pull request. Please open up a new issue to better manage the bug. |
Adds support for basic auth for exchanging access tokens. This is important since golang's oauth2 library requires that.
https://tools.ietf.org/html/rfc6749#section-2.3.1