Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add isAdmin to user API response #6231

Merged
merged 1 commit into from
Mar 3, 2019
Merged

add isAdmin to user API response #6231

merged 1 commit into from
Mar 3, 2019

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Mar 3, 2019 •
edited
Loading

Blocked by go-gitea/go-sdk#151 ( once merged, will update vendor of this PR )

Fixes #6043

@adelowo adelowo changed the title add isAdmin to user model add isAdmin to user API response Mar 3, 2019
@techknowlogick
Copy link
Member

Can you add some tests?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 3, 2019
@adelowo adelowo marked this pull request as ready for review March 3, 2019 20:03
@adelowo
Copy link
Member Author

adelowo commented Mar 3, 2019

Done

@adelowo
add isAdmin to user model
a0e94b7 
update vendor and add tests

fix swagger
@adelowo adelowo force-pushed the add_is_admin_to_user_api_format branch from 75d7b8f to a0e94b7 Compare March 3, 2019 21:45
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 3, 2019
@lafriks lafriks added this to the 1.8.0 milestone Mar 3, 2019
@codecov-io
Copy link

Codecov Report

Merging #6231 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6231      +/-   ##
==========================================
- Coverage   38.85%   38.84%   -0.01%     
==========================================
  Files         354      354              
  Lines       50221    50223       +2     
==========================================
- Hits        19515    19511       -4     
- Misses      27880    27885       +5     
- Partials     2826     2827       +1
Impacted Files Coverage Δ
routers/api/v1/user/user.go 23.35% <0%> (-0.18%) ⬇️
models/user.go 49.76% <100%> (+0.04%) ⬆️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo_list.go 66.84% <0%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e202e2...a0e94b7. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 3, 2019
@techknowlogick techknowlogick merged commit 141c58f into go-gitea:master Mar 3, 2019
@adelowo adelowo deleted the add_is_admin_to_user_api_format branch March 4, 2019 07:06
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

[API] Flag to show if a user is admin or user
6 participants
@adelowo @techknowlogick @codecov-io @lafriks @zeripath @GiteaBot