Change sqlite DB path default to data directory

[jolheiser]

As titled, split from #6176

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@b03d780). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #6198   +/-   ##
=========================================
  Coverage          ?   38.86%           
=========================================
  Files             ?      354           
  Lines             ?    50192           
  Branches          ?        0           
=========================================
  Hits              ?    19508           
  Misses            ?    27859           
  Partials          ?     2825

Impacted Files	Coverage Δ
models/models.go	51.96% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b03d780...9889a6c. Read the comment docs.

[lunny]

And why not filepath.Join?

[jolheiser]

I was unaware there were two different common join methods. Go has a few of these interesting "features" I've noticed.

After reading the docs and differences, filepath probably makes more sense here, though throughout the code I see both methods being used somewhat interchangeably.

Would you prefer I change it to filepath?

[jolheiser]

@lunny @techknowlogick I doubt it would change your review, but just an FYI that I changed path.Join to filepath.Join 👍

[MCF]

FWIW, I did some research into path vs. filepath in go, and how it impacts paths in Windows. Turns out it is not that much of a problem in most cases:

#2845

There are a few additional notes in the pull request that fixed that issue if you are interested in all the gory details.

[jolheiser]

Thanks for the info! That's more or less what I read when looking in to it as well.
Paths to a file (or other system location) should generally use filepath

As Go explains it:

The filepath package uses either forward slashes or backslashes, depending on the operating system. To process paths such as URLs that always use forward slashes regardless of the operating system, see the path package.

[techknowlogick]

Thanks for making this change 😃

[MCF]

It is true that filepath is preferable. But I found in my testing that Go is very forgiving with the slashes, so you can mix and match slashes as you wish and Go will "do the right thing" in most cases on any operating systems. In other words you can actually be pretty lazy about using path instead of filepath and get away with it in almost all cases.

The fly in the ointment that I found was UNC paths (i.e. Windows files share paths like: \\my-cool-share\data\test.txt). Path does not always "do the right thing" with those paths. But filepath does.

But fundamentally everyone is right in saying that filepath should be used for paths to the filesystem. I was just trying to provide context around why it still (mostly) works if you don't.