UI: Style tweaks to issue selection #6196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
silverwind
commented
Feb 26, 2019
silverwind
commented
- Prevent jump in layout when selecting the first issue
- Remove useless padding on top of first issue
- Prevent jump in layout when selecting the first issue - Remove useless padding on top of first issue
silverwind
commented
Feb 26, 2019
| #issue-actions { | ||
| margin-top: -1rem !important; // counteract padding from Semantic | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
The extra margin comes from Semantic's .ui .grid + .grid. I was not able to overrule their rule with a margin-top: 0 for some reason, so I went with this instead.
GiteaBot
added
the
lgtm/need 2
Codecov Report
@@ Coverage Diff @@
## master #6196 +/- ##
=========================================
Coverage ? 38.87%
=========================================
Files ? 354
Lines ? 50192
Branches ? 0
=========================================
Hits ? 19510
Misses ? 27857
Partials ? 2825Continue to review full report at Codecov.
|
lafriks
approved these changes
Feb 27, 2019
GiteaBot
added
lgtm/need 1
hexfs
approved these changes
Feb 27, 2019
techknowlogick
approved these changes
Feb 27, 2019
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.