Make repo creation for API similar to UI #6142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when creating a repo via the API and using the
auto_init
key while leaving thereadme
key blank, Gitea returns a 500 errorAsset readme not found
This PR checks if
auto_init
was set totrue
andreadme
is left blank, setreadme
toDefault
.On the UI, readme is defaulted as
Default
which is why the UI never encounters this error.If it would make more sense to handle this "defaultness" in the model, I can move it there. I only added it to the API to mirror what the UI does.
One issue I can think of is if someone builds Gitea from source without bindata and removed the
Default
readme, this would no longer work. Not sure if that's in the scope of this PR though...