-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to ldap.v3 to fix #5928 #6105
Merged
zeripath
merged 2 commits into
go-gitea:master
from
zeripath:issues-5928-move-to-ldap.v3
Feb 18, 2019
Merged
Move to ldap.v3 to fix #5928 #6105
zeripath
merged 2 commits into
go-gitea:master
from
zeripath:issues-5928-move-to-ldap.v3
Feb 18, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## master #6105 +/- ##
==========================================
+ Coverage 38.85% 38.86% +<.01%
==========================================
Files 345 345
Lines 49510 49510
==========================================
+ Hits 19237 19241 +4
+ Misses 27491 27486 -5
- Partials 2782 2783 +1
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Feb 17, 2019
lafriks
approved these changes
Feb 18, 2019
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Feb 18, 2019
lunny
approved these changes
Feb 18, 2019
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Feb 18, 2019
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Feb 18, 2019
Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #5928 - this PR moves to ldap.v3 in an attempt to fix the regressions seen in LDAP.
I don't have a decent test case for this so I'm only working off what has been suggested.
Signed-off-by: Andrew Thornton art27@cantab.net