Skip to content

Conversation

@zeripath
Copy link
Contributor

As suggested in #5928 - this PR moves to ldap.v3 in an attempt to fix the regressions seen in LDAP.

I don't have a decent test case for this so I'm only working off what has been suggested.

Signed-off-by: Andrew Thornton art27@cantab.net

Signed-off-by: Andrew Thornton <art27@cantab.net>
@codecov-io
Copy link

codecov-io commented Feb 17, 2019

Codecov Report

Merging #6105 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6105      +/-   ##
==========================================
+ Coverage   38.85%   38.86%   +<.01%     
==========================================
  Files         345      345              
  Lines       49510    49510              
==========================================
+ Hits        19237    19241       +4     
+ Misses      27491    27486       -5     
- Partials     2782     2783       +1
Impacted Files Coverage Δ
modules/auth/ldap/ldap.go 54.4% <ø> (ø) ⬆️
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️
routers/repo/view.go 46.22% <0%> (+1.16%) ⬆️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a380cfd...036e41e. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 17, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 18, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 18, 2019
@zeripath zeripath merged commit 22770c3 into go-gitea:master Feb 18, 2019
@zeripath zeripath deleted the issues-5928-move-to-ldap.v3 branch February 18, 2019 12:34
zeripath added a commit to zeripath/gitea that referenced this pull request Feb 18, 2019
Signed-off-by: Andrew Thornton <art27@cantab.net>
@lafriks lafriks added the backport/done All backports for this PR have been created label Feb 18, 2019
zeripath added a commit that referenced this pull request Feb 18, 2019
Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants