Update bleve dependency to latest master revision #6100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6100 +/- ##
=======================================
Coverage 38.86% 38.86%
=======================================
Files 345 345
Lines 49510 49510
=======================================
Hits 19241 19241
Misses 27486 27486
Partials 2783 2783Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
techknowlogick
added
the
topic/build
| name = "github.com/blevesearch/bleve" | ||
| #Not targetting v0.7.0 since standard where use only just after this tag |
There was a problem hiding this comment.
Near bottom of this file you can remove constraint on github.com/go-gitea/bolt"
There was a problem hiding this comment.
I think we should still fix revision to have predictable build
lunny
force-pushed
the
lunny/update_bleve
branch
from
3b04f30
to
98ee0cb
Compare
lafriks
approved these changes
Feb 17, 2019
GiteaBot
added
lgtm/need 1
lafriks
changed the title
adelowo
approved these changes
Feb 17, 2019
GiteaBot
added
lgtm/done
|
Needs a milestone setting... 1.8.0 or 1.9.0? |
|
I’m going to set as 1.8 because it is a requirement to make this switch for go modules |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will unblock #5044