Allow labels to contain emoji

[jolheiser]

Resolves #6062

In my opinion they seem a little bulky...
Look at below comments for updated images.

[codecov-io]

Codecov Report

Merging #6063 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #6063      +/-   ##
==========================================
+ Coverage   38.86%   38.87%   +<.01%     
==========================================
  Files         345      345              
  Lines       49507    49508       +1     
==========================================
+ Hits        19241    19246       +5     
+ Misses      27483    27480       -3     
+ Partials     2783     2782       -1

Impacted Files	Coverage Δ
routers/repo/issue_label.go	46.76% <0%> (-0.34%)	⬇️
models/repo_list.go	64.55% <0%> (+1.26%)	⬆️
modules/process/manager.go	81.15% <0%> (+4.34%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c8ac1a...0a59606. Read the comment docs.

[markusamshove]

I did the same find and replace to test this out locally, but you've beat me in creating a PR :-)

I've seen that in the labels overview the labels to have a label icon at the beginning, maybe this has a different css class and fits better?

[jolheiser]

Looks as though Semantic got excited about label images and made their height !important

As much as I hate using !important to fight other !important rules, it seems that until we re-design without Semantic this might be the best choice. I will add another style for these labels for now to correct the emoji size.

Compare these new images with the old ones in the original comment.

[silverwind]

Semantic is full of weird hacks like that 😢

Looking at your screenshots, I think the emojis are still a little bit too big and seem not exactly vertically centered in some cases. Maybe you could get them a bit closer to GitHub's styling:

g-emoji {
    font-family: Apple Color Emoji,Segoe UI,Segoe UI Emoji,Segoe UI Symbol;
    font-size: 1.2em;
    font-weight: 400;
    line-height: 20px;
    vertical-align: middle;
}

g-emoji img {
    height: 1em;
    width: 1em;
}

.IssueLabel .g-emoji {
    display: inline-block;
    font-size: 1em;
    line-height: 1;
    position: relative;
    top: -.05em;
}

.IssueLabel--big .g-emoji {
    display: inline-block;
    margin-top: -1px;
}

[jolheiser]

Hmmm....I'm not sure I agree. This is at 1em and I think it's a tad too small, some of the emoji are getting hard to recognize.
Ultimately I'll go with what most people prefer, but as it stands I think I prefer the images above this one.
The images above are at 1.5em for reference, so there's technically .5em lee-way to work with. 😉

[silverwind]

I like them at 1em, but wouldn't mind a bit bigger, maybe 1.2em. Maybe also match the size of emojis in regular text (I imagine anything bigger than 1em will introduce unwanted whitespace in the line).

[jolheiser]

I think 1.2em looks fine.

[lafriks]

Ouch... It was for 1.9.0... sry, already merged :)

[jolheiser]

Ugh, sorry about the Makefile. I've been trying to keep up with that and removing it before committing.
Darn Windows being difficult.