-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Make dashboard navbar and footer full-width #6013
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6013 +/- ##
=========================================
Coverage ? 38.73%
=========================================
Files ? 332
Lines ? 48992
Branches ? 0
=========================================
Hits ? 18975
Misses ? 27269
Partials ? 2748 Continue to review full report at Codecov.
|
@silverwind thanks! Any chance to let all the pages full-width? |
Possible, but each page will need individual care because some of them don't look too good at full width, especially on smaller zoom levels, so we have to do individual fixes. I plan on starting with the dashboard later. |
73b42b3
to
f1ff673
Compare
6eb85c5
to
9c6a60f
Compare
One more tweak related to the footer. On small pages, there were unneccessary scrollbars because the page layout was 100% + 1px high with that 1px coming from the footer border. For some reason I had to add one more pixel to prevent the scrollbar from appearing. Maybe refactor to flexbox later. |
As @lunny suggested, make the dashboard navbar full-width as well.
Before
After